emit export errors properly and move cleanup #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
sssoleileraaa
force-pushed
the
607-fix
branch
from
3f8d17e
to
e315ff8
Compare
emkll
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Tested in Qubes in sd-svs using a deb file built from this branch. I can no longer reproduce #607. I am now prompted to try entering the password again. Normal (non-preflight-failing path) also works as expected.
Thanks @creviera !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #607