Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sdk in dev-requirements #629

Merged
merged 1 commit into from Nov 25, 2019
Merged

update sdk in dev-requirements #629

merged 1 commit into from Nov 25, 2019

Conversation

sssoleileraaa
Copy link
Contributor

Description

Updates sdk dev-requirements.txt

Test Plan

  1. run pip install -r dev-requirements.txt and see that sdk 0.0.12 gets installed
  2. make sure you are able to log into the client

Checklist

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Nov 23, 2019
kushaldas
kushaldas approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sha256sum is correct. Approved.

@kushaldas kushaldas merged commit 1fafa5c into master Nov 25, 2019
SecureDrop Team Board automation moved this from Ready for Review to Done Nov 25, 2019
@kushaldas kushaldas deleted the update-sdk branch November 25, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sssoleileraaa @kushaldas