Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around (not bug fix) for issue #684. #686

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Jan 8, 2020

Description

Fixes ##684.

This was an adventure. After exploring a Qt rabbit hole I proved my hunch was correct (the size of the QLabel wasn't being redrawn when the setText method was called, hence the truncated text). Investigating a workaround ended up with the first commit which was created because I was unaware of the adjustSize method on the QWidget base class. However, once I found it, I scratched by work-around approach and now it works. :-)

Test Plan

None (needed).

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

@kushaldas
Copy link
Contributor

@ntoll can you please add a screenshot pointing exactly where to check that this PR is doing it's work?

Before and after screenshots will be better.

@ntoll
Copy link
Contributor Author

ntoll commented Jan 8, 2020

A mentioned in Slack, there's a screenie in #684.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me as suggested.

@kushaldas kushaldas merged commit ceae5f0 into freedomofpress:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants