Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default highlight for source in source list #696

Merged
merged 1 commit into from Jan 13, 2020
Merged

remove default highlight for source in source list #696

merged 1 commit into from Jan 13, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #331 which was reintroduced at some point.

See how the first item in the SourceList is highlighted when nothing is displaying for that source. Also the highlight coloring is using the QListView default instead of our own:

highlight-incorrect

Test Plan

  1. Log into the client in offline mode and now see that the first item is not highlighted. Also when you select an item in the source list it will appear with the correct highlight color, see:

Screenshot from 2020-01-10 16-39-43

Screenshot from 2020-01-10 16-39-55

@sssoleileraaa sssoleileraaa changed the title fix selection coloring for source list remove default highlight for source in source list Jan 11, 2020
@sssoleileraaa sssoleileraaa added this to Ready for Review in SecureDrop Team Board Jan 11, 2020
kushaldas
kushaldas approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised. Approved.

no_issues_offline_qlist

@kushaldas kushaldas merged commit 15314ae into master Jan 13, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 13, 2020
@kushaldas kushaldas deleted the fix-qlistview-item-selected branch January 13, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shrinking size of window can cause sources in the source list to disappear
2 participants
@sssoleileraaa @kushaldas