Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML entities being escaped in speech bubbles. #703

Merged

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Jan 16, 2020

Description

Fixes #644. Fixes #645 .

I agree with and have followed @emkll's suggestion for the fix.

Test Plan

Updated unit tests to reflect changes.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@eloquence
Copy link
Member

Cross-referencing a bug with not correctly escaping bugs in the newly introduced snippets: #706

@kushaldas kushaldas self-assigned this Jan 20, 2020
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sd_client_text_label

Works, thank you :)

@kushaldas kushaldas merged commit 7e876d7 into freedomofpress:master Jan 20, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 20, 2020
@rmol rmol mentioned this pull request Jan 28, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Replies with <>& are escaped with HTML entities Placeholder messages display with HTML entities
3 participants