Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/queue: prioritize user-triggered state changes #708

Merged
merged 1 commit into from Jan 20, 2020

Conversation

redshiftzero
Copy link
Contributor

Description

Fixes #657

Test Plan

In terms of testing, you can test interactively in Qubes but I think determining if you agree with the following logic is sufficient for merge:

  1. User-triggered actions should be as fast as possible
  2. File downloads happen in another queue so it doesn't really matter what priority they are
  3. Metadata syncs will be moved in Separate MetadataSyncJob from main queue and increase frequency of background syncs #652

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Approved.

@kushaldas kushaldas merged commit 3bb0e7d into master Jan 20, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 20, 2020
@kushaldas kushaldas deleted the deprioritize-downloads branch January 20, 2020 10:10
@rmol rmol mentioned this pull request Jan 28, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Deprioritize background jobs over user-initiated actions
2 participants