Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show a short notification when new messages about to download #822

Merged
merged 2 commits into from Mar 2, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Description

Towards #775

This implements the part where we add the "Retrieving new messages" notification, but instead of it remaining until the last download job is finished, the notification will last 2.5s.

Test Plan

  1. Send a message or more as a source
  2. Right after a sync see the "Retrieving new messages" notifcation for 2.5s

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

@kushaldas
Copy link
Contributor

This PR requires a rebase.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@redshiftzero redshiftzero merged commit 54fa1d2 into master Mar 2, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Mar 2, 2020
@redshiftzero redshiftzero deleted the retrieving-new-messages branch March 2, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants