Fixes #232 Uses python3 setuptools for sdist #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using the Python3 setuptools package to create the source tarballs.
|
I am wondering why is it trying to build the |
|
CI is likely failing here de due to changes in the dom0 build logic introduced in freedomofpress/securedrop-workstation#666 |
emkll
force-pushed
the
use_python3_setuptools
branch
2 times, most recently
from
fdc36d8
to
4c795b2
Compare
CI builds are currently failing due to recent changes introduced in freedomofpress/securedrop-workstation#666. Now that we have reproducible builds, we can revisit the nightly rpm builds later.
emkll
force-pushed
the
use_python3_setuptools
branch
from
4c795b2
to
42a185f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using the Python3 setuptools package
to create the source tarballs.
Fixes #232
How to test?
python-setuptoolsis installed in the systemPKG_VERSION=0.4.1 make securedrop-clientshould be able build the package following the standard build procedure.