-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate and update workstation release management process #30
Consolidate and update workstation release management process #30
Conversation
d63d1fa
to
34393c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't stop myself from reading through. I know this is a draft, but I thought it was worth taking note of what I noticed as I read, I hope that's not annoying 😬
Obviously feel free to ignore my comments! (I think that dismissing the review would hide them all at once... not sure, but I'd expect that.)
These updates read great too! Thanks you so much for re-organizing these docs @creviera 🙌
34393c8
to
42d240c
Compare
Signed-off-by: Allie Crevier <allie@freedom.press>
5291682
to
429499f
Compare
[Blocked on https://github.com/https://github.com/freedomofpress/infrastructure/pull/4068 + tandem PR for securedrop repos + actually renaming the repos] |
Need to fix some linter errors later today and then I'll mark this ready for review. Once this is merged, freedomofpress/securedrop-builder#400 can be merged. |
429499f
to
77d96bd
Compare
@gonzalo-bulnes, this should be ready for another review. I threw it on the SecureDrop "Ready for Review" column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few typos, the write up itself reads great! ⭐
77d96bd
to
bf7ac40
Compare
476c63f
to
1e5c5da
Compare
1e5c5da
to
6cf5127
Compare
This should be ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status
Ready for review
Closes #27
Description of Changes
The workstation release management docs were difficult to read and scattered, so I did some work on consolidating the release instructions nested in the
securedrop-builder
README with the release managment instructions here. I also spent quite a bit of time on simplifying and clarifying the required steps for a release.Related but separate issue: #36
Checklist (Optional)
make docs-lint
) passed locallymake docs-linkcheck
) passedmake docs
) docs at http://localhost:8000