Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and update workstation release management process #30

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Nov 23, 2022

Status

Ready for review

Closes #27

Description of Changes

The workstation release management docs were difficult to read and scattered, so I did some work on consolidating the release instructions nested in the securedrop-builder README with the release managment instructions here. I also spent quite a bit of time on simplifying and clarifying the required steps for a release.

Related but separate issue: #36

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

@sssoleileraaa sssoleileraaa marked this pull request as draft November 23, 2022 08:40
@sssoleileraaa sssoleileraaa changed the title consolidate and update workstation release management process Consolidate and update workstation release management process Nov 23, 2022
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from d63d1fa to 34393c8 Compare November 23, 2022 09:06
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't stop myself from reading through. I know this is a draft, but I thought it was worth taking note of what I noticed as I read, I hope that's not annoying 😬

Obviously feel free to ignore my comments! (I think that dismissing the review would hide them all at once... not sure, but I'd expect that.)

These updates read great too! Thanks you so much for re-organizing these docs @creviera 🙌

docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Show resolved Hide resolved
docs/workstation_release_management.rst Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Show resolved Hide resolved
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 34393c8 to 42d240c Compare February 10, 2023 00:40
Signed-off-by: Allie Crevier <allie@freedom.press>
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 5291682 to 429499f Compare February 10, 2023 01:35
@sssoleileraaa
Copy link
Contributor Author

[Blocked on https://github.com/https://github.com/freedomofpress/infrastructure/pull/4068 + tandem PR for securedrop repos + actually renaming the repos]

@sssoleileraaa
Copy link
Contributor Author

Need to fix some linter errors later today and then I'll mark this ready for review. Once this is merged, freedomofpress/securedrop-builder#400 can be merged.

@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 429499f to 77d96bd Compare February 22, 2023 02:49
@sssoleileraaa sssoleileraaa marked this pull request as ready for review February 22, 2023 02:55
@sssoleileraaa
Copy link
Contributor Author

@gonzalo-bulnes, this should be ready for another review. I threw it on the SecureDrop "Ready for Review" column

Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few typos, the write up itself reads great! ⭐

docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
docs/workstation_release_management.rst Outdated Show resolved Hide resolved
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 77d96bd to bf7ac40 Compare February 22, 2023 17:35
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 476c63f to 1e5c5da Compare February 22, 2023 20:07
@sssoleileraaa sssoleileraaa force-pushed the release-management-and-securedrop-builder branch from 1e5c5da to 6cf5127 Compare February 22, 2023 20:20
@sssoleileraaa
Copy link
Contributor Author

This should be ready for another review.

Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gonzalo-bulnes gonzalo-bulnes merged commit c49f2bf into main Feb 22, 2023
@legoktm legoktm deleted the release-management-and-securedrop-builder branch May 28, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate securedrop-builder README
3 participants