Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Date Formatting to guidelines #107

Merged
merged 1 commit into from Nov 30, 2020

Conversation

buildbricks
Copy link
Contributor

Status

Ready for review

Description of Changes

Testing

Release

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

@buildbricks
Copy link
Contributor Author

@eloquence

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Nov 18, 2020
LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change, otherwise LGTM :). Thanks @joaedwar

@eloquence eloquence moved this from Ready for Review to In Development in SecureDrop Team Board Nov 18, 2020
@buildbricks
Copy link
Contributor Author

@eloquence was this changed back?

@eloquence
Copy link
Member

@joaedwar What do you mean? I've not pushed to your branch, if that's what you're asking. The pending change (to restore the license to its original state) is still pending.

Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the LICENSE file change and updated your branch accordingly; this is now good to go, so merging.

@eloquence eloquence merged commit 5ae2742 into freedomofpress:main Nov 30, 2020
SecureDrop Team Board automation moved this from In Development to Done Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Standardize preferred date/time format in docs guidelines
2 participants