Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace qa_loader.py with loaddata.py #108

Merged
merged 1 commit into from Jan 8, 2021

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Nov 18, 2020

Status

Ready for review

Description of Changes

Updates the documentation for the convergence of qa_loader.py and create-dev-data.py into loaddata.py.

Testing

Visual review should suffice.

Release

This should be merged after freedomofpress/securedrop#5645 has landed in develop.

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed (only failed because of GitHub 429s)
  • You have previewed (make docs) docs at http://localhost:8000

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Nov 18, 2020
@zenmonkeykstop zenmonkeykstop moved this from Ready for Review to Under Review in SecureDrop Team Board Nov 24, 2020
@zenmonkeykstop zenmonkeykstop self-assigned this Nov 24, 2020
@rmol rmol removed the blocked label Dec 21, 2020
@rmol rmol moved this from Under Review to Ready for Review in SecureDrop Team Board Dec 21, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review

@zenmonkeykstop zenmonkeykstop merged commit fc1d837 into main Jan 8, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants