Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to include instructions for unattended-upgrades under Ubuntu Focal #146

Merged
merged 2 commits into from Mar 4, 2021

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 3, 2021

Status

Ready for review

Description of Changes

Testing

Instructions are logical and manual upgrade logic works in both Xenial (cron-apt) and Focal (unattended-upgrades)

Release

  • The instructions are listed for both Xenial and Focal instances, though some

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

rocodes
rocodes previously approved these changes Feb 4, 2021
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review. I left one small comment but it's not a showstopper. Thanks @emkll :)

(Making a mental note: reviewing this PR made me re-read the "Partitioning the disks" section of the install docs, and maybe we should simplify that section just to say "don't enable FDE." The way we currently word it, introduce FDE, and then strongly recommend not to use it is a bit confusing. If others agree, I'll open an issue. However, I think that's out of scope for this PR).

docs/admin.rst Outdated
and you are using SSH-over-Tor), your SSH connection may be interrupted, and you
SecureDrop will update and reboot once per day. However, once a SecureDrop
update `is announced`_ , you can opt to fetch the update immediately. Depending
on the nature of the update (e.g., if the ``tor`` package is upgraded and you are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit) for clarity's sake, I would move the "Depending on the nature of the update, ..." sentence to the very end of these instructions (current line 451), optionally in a note. But I don't think it's worth doing unless other people request other changes as well.

Starting with Ubuntu 20.04, we plan on using unattended-upgrades instead
of  cron-apt.
@emkll
Copy link
Contributor Author

emkll commented Feb 15, 2021

freedomofpress/securedrop#5684 has been merged, rebased on latest main

@emkll emkll marked this pull request as ready for review February 15, 2021 21:25
@emkll emkll added this to Ready for Review in SecureDrop Team Board Feb 15, 2021
@eloquence eloquence moved this from Ready for Review to Under Review in SecureDrop Team Board Mar 4, 2021
@eloquence eloquence self-assigned this Mar 4, 2021
Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not test on a Focal instance but matches documented behavior of the unattended-upgrades tool. Made two small tweaks - lower-cased the version IDs as in the os-release file, and moved the note per Ro's comment.

@eloquence eloquence merged commit f8f2d70 into main Mar 4, 2021
SecureDrop Team Board automation moved this from Under Review to Done Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants