This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
logging audit #61
Merged
logging audit #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkll
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Thanks @redshiftzero changes look good to me, tested in qubes by installing the deb package manually in my sd-devices VM. Filename is no longer logged, and don't see file name in logs for both export methods (print+usb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards freedomofpress/securedrop-workstation#397
I interactively ran through USB export and printing in Qubes on this wee diff to make sure we're not logging any: passphrases or files of original source documents. Bonus points for doing the same but otherwise just scanning through the log lines yourself is sufficient.