Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Change driver/PPD used for Brother printers #62

Closed
wants to merge 2 commits into from

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 25, 2020

Fixes freedomofpress/securedrop-workstation#506, or at least makes it possible to print the image that prompted the issue, and continues to print other file types as well.

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Mar 26, 2020
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the brother printer story is not going to be easy. My DCP-7065DN
throws ERROR_PRINTER_NOT_FOUND error with this PR and also master. If i click on the widget to
connect the printer to the sd-devices, then our securedrop-client shows the next window after
"connect a printer"

Also, my printer is anyway getting detected by the printer dialog (it showing as the first printer).

I am also attaching the photo of the print from the master branch (pic with a yellow pen)

print_from_master

This is the print via my standard printer (using this Branch)

print_using_my_printer_driver

If I use the printer mentioned in this PR, my printer is showing "Receiving Data" and then nothing. No print at all.

@emkll
Copy link
Contributor

emkll commented Mar 26, 2020

Also experiencing some issues with the changes introduced here. I built the securedrop-export package and installed it in sd-devices. When sending a device to the printer, sdw-printer comes up as a LaserJet printer. However, I cannot print any documents. I tried:

  • .docx
  • .pdf
  • .jpg
  • .gif

The ready light flashes for ~10 seconds and then becomes solid again for pdf, jpg and pdf, and stuck at 'processing' for docx.

xpp_cups

@redshiftzero redshiftzero moved this from Ready for Review to Under Review in SecureDrop Team Board Mar 26, 2020
@eloquence
Copy link
Member

Moving this back to backlog for now. We'll revisit printer issues after the first release.

@eloquence eloquence moved this from Under Review to QA Period - 3/17-3/31 (Kanban Mode) in SecureDrop Team Board Mar 27, 2020
@eloquence eloquence moved this from Sprint #48 - 4/2-4/15 to Near Term - SD Workstation in SecureDrop Team Board Apr 2, 2020
@eloquence eloquence moved this from Near Term - SD Workstation to Discussion Points in SecureDrop Team Board Jul 1, 2020
@eloquence
Copy link
Member

(Adding to "Discussion Points" to check in on status of this PR.)

@eloquence
Copy link
Member

Given the inconsistent reports above, we've agreed to close out this change for now; we may revisit in future in context of larger improvements to printer handling.

@eloquence eloquence closed this Jul 7, 2020
@eloquence eloquence removed this from Discussion Points in SecureDrop Team Board Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve printing of images
4 participants