Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TechCrunch to ruleset #25

Merged
merged 2 commits into from Dec 22, 2020
Merged

Add TechCrunch to ruleset #25

merged 2 commits into from Dec 22, 2020

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Dec 18, 2020 •
edited by zenmonkeykstop

Status

WIP (requires signing & timestamp)

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/rocodes/securedrop-https-everywhere-ruleset/techcrunch
  • index.html has been updated using ./update_index.sh

rocodes and others added 2 commits December 18, 2020 17:18
@rocodes
Add TechCrunch to ruleset
4c0e518
Adds signature for Techcrunch addition
5c2c731 
Used the script in [0] to regenerate all the rules,
including the sig. Looks good.

[0] freedomofpress#23
@conorsch
Copy link
Contributor

@rocodes I've signed and pushed. Can you perform a functionality verification of the changes in Tor Browser, using the testing instructions from #19 (comment) ? Assuming you can confirm the functionality, we can ping another maintainer for a +1 and permit merge to prod.

@conorsch conorsch self-requested a review December 22, 2020 00:27
@zenmonkeykstop zenmonkeykstop self-assigned this Dec 22, 2020
@zenmonkeykstop
Copy link
Contributor

As per earlier, I'm grabbing this for verification purposes

@conorsch conorsch changed the title Add TechCrunch to ruleset [ruleset only, needs signing] Add TechCrunch to ruleset Dec 22, 2020
@zenmonkeykstop
Copy link
Contributor

With the added update channel pulling from rocodes/techcrunch, behaves as expected. Doing rest of review now.

zenmonkeykstop
zenmonkeykstop approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist passes, this is good to go!

@zenmonkeykstop zenmonkeykstop merged commit 3e26f10 into freedomofpress:main Dec 22, 2020
@conorsch
Copy link
Contributor

Thanks, @zenmonkeykstop! I manually busted the cache on this endpoint, so the latest data should be live in prod. That is, you should be able to use it in Tor Browser, with no testing update channels, effective immediately.

@conorsch conorsch mentioned this pull request Dec 22, 2020
Merged
4 tasks
@rocodes
Copy link
Contributor Author

rocodes commented Dec 22, 2020 •
edited

@conorsch Apologies if I am misunderstanding, but I am not seeing this ruleset addition live. (Using TB 10.0.7)

@conorsch
Copy link
Contributor

@rocodes You were correct, the changes weren't yet live in prod. They are now, though, and I'm seeing the new TC redirect work in Tor Browser on my end, with no testing channels in place. Give it another try to confirm.

@rocodes
Copy link
Contributor Author

rocodes commented Dec 23, 2020

Success! Thank you for the speedy resolution @conorsch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenmonkeykstop zenmonkeykstop zenmonkeykstop approved these changes

@conorsch conorsch Awaiting requested review from conorsch

Assignees

@zenmonkeykstop zenmonkeykstop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rocodes @conorsch @zenmonkeykstop