Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iROZHLAS.cz to ruleset #27

Merged
merged 3 commits into from Jan 26, 2021
Merged

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Jan 12, 2021

Status

Fixes #20

Ready for Review

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/rocodes/securedrop-https-everywhere-ruleset/irozhlas
  • index.html has been updated using ./update_index.sh

@rocodes rocodes requested a review from conorsch January 12, 2021 20:26
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Jan 25, 2021
@emkll emkll self-requested a review January 25, 2021 18:26
@emkll emkll self-assigned this Jan 25, 2021
The slug on securedrop.org is `abc`, and to avoid coding a special case, we should just preserve the original naming per the website's slug.
@emkll emkll removed their assignment Jan 25, 2021
@emkll
Copy link
Contributor

emkll commented Jan 25, 2021

I've updated this PR with a signature and successfully ran through the test plan. This should now be ready for final review.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working via test update channel in Tor Browser.

@conorsch conorsch merged commit 185babd into freedomofpress:main Jan 26, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Duplicate ABC ruleset is generated
3 participants