Adds rules for Stefania Maurizi and Forbes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2021 13:26
emkll
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Thanks @conorsch changes look good to me
- Changes to
onboarded.txtare accurate - The file
default.rulesets.TIMESTAMP.gzhas been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules - The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to
Path Prefix:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/24-26-maurizi-and-forbes -
index.htmlhas been updated using./update_index.sh
I think in the future we can simply generate a single ruleset/commit per PR, since it's unlikely we will use the first ruleset or revert to that commit once we add another entry to the ruleset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Makes two (2) additions to the rulesets. Closes #24. Closes #26.
Review Checklist
onboarded.txtare accuratedefault.rulesets.TIMESTAMP.gzhas been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAMEindex.htmlhas been updated using./update_index.sh