Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Starts the service after redis #12

Merged
merged 1 commit into from Feb 11, 2020
Merged

Starts the service after redis #12

merged 1 commit into from Feb 11, 2020

Conversation

kushaldas
Copy link
Contributor

Starts the securedrop-log service only after the redis service is running.

This is something I found while working on freedomofpress/securedrop-workstation#447

@eloquence eloquence removed the Blocked label Feb 11, 2020
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Feb 11, 2020
@emkll emkll self-requested a review February 11, 2020 17:12
@emkll emkll moved this from Ready for Review to Under Review in SecureDrop Team Board Feb 11, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushaldas I've tested the changes locally as follows:
I have built a package from this branch and installed the package in securedrop-log-buster-template, and the logs are still flowing through to sd-log after a reboot. Combined with a visual diff review, I think this is fine to merge in order to unblock work #447.

@emkll emkll merged commit d1799b2 into master Feb 11, 2020
SecureDrop Team Board automation moved this from Under Review to Done Feb 11, 2020
@emkll emkll deleted the start_after_redis branch February 11, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants