This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Uses new reproducible wheels from our builds #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kushaldas
force-pushed
the
reproducible_wheels_usage
branch
from
2fd62a9
to
e540e0c
Compare
conorsch
approved these changes
Jan 9, 2021
There was a problem hiding this comment.
Manually verified the new checksum matches what's shown in freedomofpress/securedrop-builder#213. Approving, but not merging, since there's still a temporary commit that should be removed.
The new wheels are coming in the following PR: freedomofpress/securedrop-builder#213 These wheels are reproducible, you can build them following our Makefile.
conorsch
force-pushed
the
reproducible_wheels_usage
branch
from
e540e0c
to
0329232
Compare
|
For reference, the historical CI build showing all tests passing can be found here: https://app.circleci.com/pipelines/github/freedomofpress/securedrop-log/60/workflows/a1a03582-be5f-46dd-a131-d07aca520156/jobs/77 I've removed the temporary feature branch pin, and will proceed with merge, verifying all tests are passing over in freedomofpress/securedrop-builder#213 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new wheels are coming in the following PR:
freedomofpress/securedrop-builder#213
These wheels are reproducible, you can build them following our
Makefile.
How to test?
They sha256sums should match with the above mentioned PR.
https://github.com/freedomofpress/securedrop-debian-packaging/pull/213/files#diff-7899317ed7333cf6bdab16b9bf5773f780ecb55b11114fc715e9240b16fd76ff
There is a temporary commit, which we can remove before merge.