Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Bump werkzeug from 0.14.1 to 0.15.3 #46

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 18, 2019

Bumps werkzeug from 0.14.1 to 0.15.3.

Release notes

Sourced from werkzeug's releases.

0.15.3

0.15.2

0.15.1

0.15.0

Changelog

Sourced from werkzeug's changelog.

Version 0.15.3

Released 2019-05-14

  • Properly handle multi-line header folding in development server in
    Python 2.7. (:issue:1080)
  • Restore the response argument to :exc:~exceptions.Unauthorized.
    (:pr:1527)
  • :exc:~exceptions.Unauthorized doesn't add the WWW-Authenticate
    header if www_authenticate is not given. (:issue:1516)
  • The default URL converter correctly encodes bytes to string rather
    than representing them with b''. (:issue:1502)
  • Fix the filename format string in
    :class:~middleware.profiler.ProfilerMiddleware to correctly handle
    float values. (:issue:1511)
  • Update :class:~middleware.lint.LintMiddleware to work on Python 3.
    (:issue:1510)
  • The debugger detects cycles in chained exceptions and does not time
    out in that case. (:issue:1536)
  • When running the development server in Docker, the debugger security
    pin is now unique per container.

Version 0.15.2

Released 2019-04-02

  • Rule code generation uses a filename that coverage will ignore.
    The previous value, "generated", was causing coverage to fail.
    (:issue:1487)
  • The test client removes the cookie header if there are no persisted
    cookies. This fixes an issue introduced in 0.15.0 where the cookies
    from the original request were used for redirects, causing functions
    such as logout to fail. (:issue:1491)
  • The test client copies the environ before passing it to the app, to
    prevent in-place modifications from affecting redirect requests.
    (:issue:1498)
  • The "werkzeug" logger only adds a handler if there is no handler
    configured for its level in the logging chain. This avoids double
    logging if other code configures logging first. (:issue:1492)

Version 0.15.1

Released 2019-03-21

  • :exc:~exceptions.Unauthorized takes description as the first
... (truncated)
Commits
  • 9b1123a release version 0.15.3
  • 00bc43b unique debugger pin in Docker containers
  • 2cbdf2b Merge pull request #1542 from asottile/exceptions_arent_always_hashable
  • 0e669f6 Fix unhashable exception types
  • bdc17e4 Merge pull request #1540 from pallets/break-tb-cycle
  • 44e38c2 break cycle in chained exceptions
  • 777500b Merge pull request #1518 from NiklasMM/fix/1510_lint-middleware-python3-compa...
  • e00c7c2 Make LintMiddleware Python 3 compatible and add tests
  • d590cc7 Merge pull request #1539 from pallets/profiler-format
  • 0388fc9 update filename_format for ProfilerMiddleware.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [werkzeug](https://github.com/pallets/werkzeug) from 0.14.1 to 0.15.3.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/master/CHANGES.rst)
- [Commits](pallets/werkzeug@0.14.1...0.15.3)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 18, 2019
@redshiftzero
Copy link
Contributor

to investigate: why is the build passing here? we haven't updated our pip mirror (which is where the hashes in build-requirements.txt comes from)

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Oct 21, 2019
--hash=sha256:e23d0cc5299223dcc37885dae624f382297717e459ea24053709675a976a3e19
requests==2.20.0 \
--hash=sha256:99dcfdaaeb17caf6e526f32b6a7b780461512ab3f1d992187801694cba42770c \
--hash=sha256:a84b8c9ab6239b578f22d1c21d51b696dcfe004032bb80ea832398d6909d7279
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(test job fails because requests is removed in this diff)

@kushaldas
Copy link
Contributor

to investigate: why is the build passing here? we haven't updated our pip mirror (which is where the hashes in build-requirements.txt comes from)

Somehow the build used old (committed build-requirements.txt ) file.

Collecting werkzeug==0.14.1

I am looking more into this.

@sssoleileraaa sssoleileraaa moved this from Ready for Review to Under Review in SecureDrop Team Board Oct 23, 2019
@sssoleileraaa sssoleileraaa moved this from Under Review to Ready for Review in SecureDrop Team Board Oct 23, 2019
@kushaldas
Copy link
Contributor

The python setup.py sdist is creating a source tarball which seems to be from the master branch. Even though in the step before we can clearly see that the PR is actually got merged on the working branch.

I could not find the step which is causing the git cleanup in the CI.

@redshiftzero
Copy link
Contributor

what's happening here is:

  1. we run make requirements in CI. This makes sure that the build-requirements.txt file has been updated based on any changes in requirements.txt. We want to keep that step since it guards against a contributor modifying requirements.txt without updating build-requirements.txt: this would break nightly builds.
  2. in this PR's diff build-requirements.txt is updated with the new version of werkzeug, but requirements.txt is not: so running make requirements overwrites build-requirements.txt with the version of werkzeug that is on master. Since all the dependencies from requirements.txt are on our pip mirror, this will build.

Some solutions:

  1. run make update-pip-requirements in CI, confirm no diff, else fail the build. This will guard against PRs in the future from bots or otherwise that update *.in without updating the corresponding *.txt files.
  2. after make requirements in CI, confirm there are no unstaged changes (e.g. via git diff-index --quiet HEAD or similar): this means that build-requirements.txt was modified in this step, and we fail the CI job with an informative message for the contributor.

I think 2 is a better solution for this specific scenario (though 1 is also probably a good idea), so will do that in a separate PR.

redshiftzero added a commit that referenced this pull request Oct 23, 2019
this guards against a scenario discovered in:

#46 (comment)

wherein a contributor would update build-requirements.txt but
not requirements.txt
redshiftzero added a commit that referenced this pull request Oct 23, 2019
this guards against a scenario discovered in:

#46 (comment)

wherein a contributor would update build-requirements.txt but
not requirements.txt
redshiftzero added a commit that referenced this pull request Oct 23, 2019
this guards against a scenario discovered in:

#46 (comment)

wherein a contributor would update build-requirements.txt but
not requirements.txt
redshiftzero added a commit that referenced this pull request Oct 23, 2019
this guards against a scenario discovered in:

#46 (comment)

wherein a contributor would update build-requirements.txt but
not requirements.txt
@redshiftzero
Copy link
Contributor

for now closing this since this needs to get re-filed after updating our pip mirror, tracked in #140 which is in the near term backlog

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Oct 24, 2019

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/werkzeug-0.15.3 branch October 24, 2019 17:10
@eloquence eloquence moved this from Ready for Review to Done in SecureDrop Team Board Oct 24, 2019
@eloquence eloquence removed this from Done in SecureDrop Team Board Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants