Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Uses new reproducible wheels from our builds #81

Merged
merged 1 commit into from Jan 26, 2021

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Jan 6, 2021

The new wheels are coming in the following PR:

freedomofpress/securedrop-builder#213

These wheels are reproducible, you can build them following our
Makefile.

How to test?

They sha256sums should match with the above mentioned PR.

https://github.com/freedomofpress/securedrop-debian-packaging/pull/213/files#diff-7899317ed7333cf6bdab16b9bf5773f780ecb55b11114fc715e9240b16fd76ff

There is a temporary commit, which we can remove before merge.

The new wheels are coming in the following PR:

freedomofpress/securedrop-builder#213

These wheels are reproducible, you can build them following our
Makefile.
@conorsch
Copy link
Contributor

conorsch commented Jan 6, 2021

Note: The package build will fail as it is dependent of the above PR to be merged.

True, although you can add a "TEMPORARY" commit to this PR that checks out the feature branch on the packaging repo. That will allow you to confirm that CI will pass post-merge of the packaging PR. It'll also help reviewers!

@kushaldas kushaldas force-pushed the update_localwheels_requirements branch from eafdebd to bcbaf22 Compare January 6, 2021 16:48
@conorsch conorsch self-requested a review January 8, 2021 23:58
conorsch
conorsch previously approved these changes Jan 9, 2021
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified the new checksums match what's shown in freedomofpress/securedrop-builder#213. Approving, but not merging, since there's still a temporary commit that should be removed.

@conorsch
Copy link
Contributor

For reference, the historical CI build showing all tests passing can be found here: https://app.circleci.com/pipelines/github/freedomofpress/securedrop-proxy/24/workflows/9507a3ac-5d10-471c-b2a8-e17b829ee8b6/jobs/370 I've removed the temporary feature branch pin, and will proceed with merge, verifying all tests are passing over in freedomofpress/securedrop-builder#213

@conorsch conorsch removed the blocked label Jan 26, 2021
@conorsch conorsch self-requested a review January 26, 2021 00:28
@conorsch conorsch merged commit b1e7de5 into main Jan 26, 2021
SecureDrop Team Board automation moved this from In Development to Done Jan 26, 2021
@conorsch conorsch deleted the update_localwheels_requirements branch January 26, 2021 00:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants