You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the "begin" status is only reported to GitHub once the Qubes VM starts. So for the period of git push --> VM start, nothing is displayed on GitHub that we're in a pending state, which can easily be tens of minutes if it's waiting for a VM. And if it fails before the VM starts (e.g. #58), there's no indication on the GH side.
The text was updated successfully, but these errors were encountered:
Move the 'Build is pending' and 'Build is running' triggers out of the sd-dev's begin.py and dom0's runner.py (respectively), and move that logic into the bastion's run.py.
You could probably just drop the 'pending' state altogether and start with 'Build is running'.
You'll need the PAT, but the bastion already has it, as it copies that file into the sd-dev VM by way of the dom0 during the build. The run.py could read it straight from /home/wscirunner/securedrop-workstation-ci/sd-dev/.sdci-ghp.txt.
You can probably leave the 'Build succeeded' / 'Build failed' in the dom0 runner.py/sd-dev, as the dom0 is best placed to know the 'status' of the build..
Currently the "begin" status is only reported to GitHub once the Qubes
VM starts. So for the period of git push --> VM start, nothing is
displayed on GitHub that we're in a pending state, which can easily be
tens of minutes if it's waiting for a VM.
We now notify GitHub at the beginning of run.py to add the status with a
message of "The build is queued." instead of in begin.py.
Fixes#63.
Currently the "begin" status is only reported to GitHub once the Qubes VM starts. So for the period of git push --> VM start, nothing is displayed on GitHub that we're in a pending state, which can easily be tens of minutes if it's waiting for a VM. And if it fails before the VM starts (e.g. #58), there's no indication on the GH side.
The text was updated successfully, but these errors were encountered: