Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub status only updated after Qubes is started #63

Closed
legoktm opened this issue Apr 30, 2024 · 1 comment · Fixed by #67
Closed

GitHub status only updated after Qubes is started #63

legoktm opened this issue Apr 30, 2024 · 1 comment · Fixed by #67
Assignees

Comments

@legoktm
Copy link
Member

legoktm commented Apr 30, 2024

Currently the "begin" status is only reported to GitHub once the Qubes VM starts. So for the period of git push --> VM start, nothing is displayed on GitHub that we're in a pending state, which can easily be tens of minutes if it's waiting for a VM. And if it fails before the VM starts (e.g. #58), there's no indication on the GH side.

@mig5
Copy link
Contributor

mig5 commented May 2, 2024

As discussed in call:

Move the 'Build is pending' and 'Build is running' triggers out of the sd-dev's begin.py and dom0's runner.py (respectively), and move that logic into the bastion's run.py.

You could probably just drop the 'pending' state altogether and start with 'Build is running'.

You'll need the PAT, but the bastion already has it, as it copies that file into the sd-dev VM by way of the dom0 during the build. The run.py could read it straight from /home/wscirunner/securedrop-workstation-ci/sd-dev/.sdci-ghp.txt.

You can probably leave the 'Build succeeded' / 'Build failed' in the dom0 runner.py/sd-dev, as the dom0 is best placed to know the 'status' of the build..

@legoktm legoktm self-assigned this May 6, 2024
legoktm added a commit that referenced this issue May 6, 2024
Currently the "begin" status is only reported to GitHub once the Qubes
VM starts. So for the period of git push --> VM start, nothing is
displayed on GitHub that we're in a pending state, which can easily be
tens of minutes if it's waiting for a VM.

We now notify GitHub at the beginning of run.py to add the status with a
message of "The build is queued." instead of in begin.py.

Fixes #63.
@cfm cfm closed this as completed in #67 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants