Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and configure securedrop-log as part of provisioning #440

Closed
emkll opened this issue Feb 5, 2020 · 2 comments · Fixed by #447
Closed

Install and configure securedrop-log as part of provisioning #440

emkll opened this issue Feb 5, 2020 · 2 comments · Fixed by #447

Comments

@emkll
Copy link
Contributor

emkll commented Feb 5, 2020

Towards #398
As discussed in sprint planning today, and per https://github.com/freedomofpress/securedrop-log/pull/8/files
We should create salt changes to automate the configuration of securedrop-log. In order to test these changes, a dev/reviewer can install securedrop-log manually in all relevant templates, and then run a makefile target (all?) to apply the configuration changes.

sd-log

  • configure /etc/qubes-rpc/securedrop.Log
  • Configure securedrop-log.service
  • Install redis{-server} packages
  • Some way of reliably restarting the services after configuration change and reboot. Maybe packaging? systemctl enable?
  • Tests to ensure configuration is correct and service is running properly

sd-{app, proxy, viewer, export...}

  • populate /etc/sd-rsyslog.conf with appropriate source/destination names
  • populate sdlog.conf in /etc/rsyslog.d/
  • Some way of reliably restarting the services after configuration change and reboot. Maybe packaging? systemctl enable?
  • test to ensure configuration is correct and service is running properly
@eloquence eloquence added this to Current Sprint (2/5-2/20) in SecureDrop Team Board Feb 5, 2020
@eloquence
Copy link
Member

FYI, we're not currently tracking any of the logging-related changes as release-blockers -- my assumption was that worst case scenario, we can still proceed without them, using (and auditing) the existing logs instead. Defer to you & Jen, happy to promote them all to release-blocker level if we feel we absolutely must land this set of changes before the pilot.

@emkll emkll changed the title Add securedrop-log configuration as part of provisioning Install and configure securedrop-log as part of provisioning Feb 6, 2020
@redshiftzero
Copy link
Contributor

Let's track these centralized logging changes as a release blocker because it's going to be significantly more challenging to do remote support without this

kushaldas added a commit that referenced this issue Feb 10, 2020
Still missing tests, and we have to make sure
that the sd-log reboots in between.
kushaldas added a commit that referenced this issue Feb 11, 2020
Still missing tests, and we have to make sure
that the sd-log reboots in between.
kushaldas added a commit that referenced this issue Feb 12, 2020
kushaldas added a commit that referenced this issue Feb 13, 2020
kushaldas added a commit that referenced this issue Feb 13, 2020
kushaldas added a commit that referenced this issue Feb 13, 2020
@eloquence eloquence removed this from Current Sprint (2/5-2/20) in SecureDrop Team Board Feb 13, 2020
kushaldas added a commit that referenced this issue Feb 14, 2020
kushaldas added a commit that referenced this issue Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants