Disables Whonix 14 repos #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
300-disable-unmaintained-whonix-14-repos
branch
from
0de2eb8
to
2b69449
Compare
We haven't migrated to Whonix 15 yet, because we're waiting for Debian 10 to become stable in the upstream Qubes repos, so we can build and serve all SDW-related packages via the buster channel. Whonix has already EOL'd 14, though, so trying to run an apt update with the old Whonix channels in place will cause apt to fail, breaking all provisioning of the sd-whonix and sd-proxy VMs. Let's disable those repos for now, to allow devs to continue to work, but the priority remains landing full Buster support across the board. We disable two possible repo configurations here, both clearnet and onion repo URLs.
conorsch
force-pushed
the
300-disable-unmaintained-whonix-14-repos
branch
from
2b69449
to
58cdf95
Compare
redshiftzero
moved this from Near Term - SD Workstation
to Nominated for Next Sprint
in SecureDrop Team Board
eloquence
moved this from Nominated for Next Sprint
to Current Sprint - 10/9-10/23
in SecureDrop Team Board
eloquence
moved this from Current Sprint - 10/9-10/23
to Ready for Review
in SecureDrop Team Board
Tests pass and I was able to log into the latest Client nightly and open submissions. |
sssoleileraaa
approved these changes
Oct 10, 2019
sssoleileraaa
moved this from Ready for Review
to Under Review
in SecureDrop Team Board
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Status: Ready for review.
Refs #300, but does not resolve.
Description
We haven't migrated to Whonix 15 yet, because we're waiting for Debian
10 to become stable in the upstream Qubes repos, so we can build and
serve all SDW-related packages via the buster channel.
Whonix has already EOL'd 14, though, so trying to run an apt update with
the old Whonix channels in place will cause apt to fail, breaking all
provisioning of the sd-whonix and sd-proxy VMs.
Let's disable those repos for now, to allow devs to continue to work,
but the priority remains landing full Buster support across the board.
We disable two possible repo configurations here, both clearnet and
onion repo URLs.
Testing
The quick-and-dirty test is the usual:
make clonemake cleanmake allmake testand confirm no errors. Depending on the state of your local environment, though, you may have already customized the
whonix-{gw,ws}-14VMs to unbreak apt, by commenting out the Whonix repos, as done in the changes presented here. In that case, a full test would ensure that a clean Whonix 14 setup still works. The test plan then becomes:make clonemake cleansudo dnf remove qubes-template-whonix-gw-14sudo dnf remove qubes-tempate-whonix-ws-14make allmake testFor myself, I used the longer test plan, and I'm able to log into the latest Client nightly and open submissions.