Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve 5% progress for VM reboot sequence #418

Merged
merged 1 commit into from Jan 31, 2020
Merged

Reserve 5% progress for VM reboot sequence #418

merged 1 commit into from Jan 31, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jan 22, 2020

Closes #411

The progress bar will now reach 100% only when reboots are applied to AppVMs

Test plan

  • On this branch: make clone, make prep-dom0
  • Make sure you have 1 vm that needs updates
  • 5% an acceptable value of progress to reserve for AppVM reboots?
  • When update are complete (and the vm reboot cascade is observed), the progress bar indicates 95%

@emkll
Reserve 5% progress for VM reboot sequence
33d7e6e 
Previously when the last VM was upgraded, the progressBar value was set to 100% due to the exiting progress calculation. By substracting 5, we ensure the progress bar is set to 95% when the time comes to reboot the AppVMs.
@emkll emkll added this to Ready for Review in SecureDrop Team Board Jan 22, 2020
rmol
rmol approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Worked as advertised; progress bar stopped at 95% for reboots.

@rmol rmol merged commit 6640271 into master Jan 31, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 31, 2020
@eloquence eloquence mentioned this pull request Jan 31, 2020
Closed
cfm pushed a commit that referenced this pull request Apr 1, 2024
@rmol
Merge pull request #418 from freedomofpress/411-progress-bar-reboot-s…
fd445e0 
…equence

Reserve 5% progress for VM reboot sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmol rmol rmol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updater progress bar should only reach 100% once all related tasks have been completed
2 participants
@emkll @rmol