Add missing files to rpmspec and manifest #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files were failing when trying to install the dom0 rpm (When attempting to apply state.highstate) sd-proxy/*, securedrop-login now found, securedrop-launcher.desktop, securedrop-login, sys-firewall/*, launcher files
Provides checklist to developers to ensure files in packaging logic are in sync with provisioning logic
Add rpm files for thsv3 support Also explicitly define file permissions
|
great catch, pushed a commit to fix. I've also provisioned with v3 and ran |
redshiftzero
approved these changes
Jan 23, 2020
|
|
||
| - [ ] Linting (`make flake8`) and tests (`make test`) pass in dom0 of a Qubes install | ||
|
|
||
| - [ ] I have added/removed files, and have updated packaging logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #406
Some files were failing when trying to install the dom0 rpm (When attempting to apply state.highstate)
Also added a pull request template to increase awareness of adding files to manifest and spec files.
Test plan:
Note that I have successfully completed the test plan below. Given the complexity of testing this relatively small diff, I would suggest the reviewer just perform a visual diff of this PR, but ultimately will leave it to their discretion.
make clean, and ensure no lingering files in/srv/saltmake dom0-rpmand copy artifact to dom0make clone(we will use the cloned repo for tests)sudo dnf install securedrop-workstation-dom0-config-0.1.1-1.fc25.noarch.rpmconfig.jsonandsd-journalist.secinto/srv/salt/sd/(needs sudo)cd /usr/share/securedrop-workstation-dom0-config./scripts/provision-all~/securedrop-workstation)make test