Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sd-log to data flow diagram #589

Merged
merged 1 commit into from Jul 21, 2020
Merged

Add sd-log to data flow diagram #589

merged 1 commit into from Jul 21, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jul 13, 2020

Status

Ready for review

Description of Changes

Adds sd-log to Data Flow Diagram

Changes proposed in this pull request:

Testing

  • Should we add sd-log to the diagram?
  • Is the DFD accurate?

Checklist

Docs/images only

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Jul 14, 2020
@eloquence
Copy link
Member

eloquence commented Jul 14, 2020 •
edited

Looks good. In my staging env I do see logs for sd-gpg in sd-log and I do see rsyslog running in sd-gpg, but it's not denoted as such here. Is that intentional?

@emkll
Copy link
Contributor Author

emkll commented Jul 14, 2020

@eloquence that is an omission in the diagram, will update

@emkll emkll moved this from Ready for Review to In Development in SecureDrop Team Board Jul 14, 2020
@emkll emkll moved this from In Development to Ready for Review in SecureDrop Team Board Jul 21, 2020
@conorsch conorsch self-requested a review July 21, 2020 21:18
@eloquence
Copy link
Member

LGTM!

@conorsch conorsch merged commit 019e1af into main Jul 21, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Jul 21, 2020
@emkll emkll deleted the dfd-add-sd-log branch July 23, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emkll @eloquence @conorsch