Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.5.5 #708

Merged
merged 2 commits into from Jun 9, 2021
Merged

Bump version to 0.5.5 #708

merged 2 commits into from Jun 9, 2021

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Jun 9, 2021

Status

Ready for review

Description of Changes

Releasing the changes merged in [0]. Intentionally
preserving the full-migration flag in postinst to trigger another
provisioning run, in order to apply this fix for those who need it.

[0] https://github.com/freedomofpress/securedrop-workstation/pull/707/files

Testing

Visual review is sufficient.

Conor Schaefer added 2 commits June 9, 2021 09:17
Follow up to #707. Make sure we're using vm_name everywhere.
Releasing the changes merged in [0]. Intentionally
preserving the full-migration flag in postinst to trigger another
provisioning run, in order to apply this fix for those who need it.

[0] https://github.com/freedomofpress/securedrop-workstation/pull/707/files
@conorsch
Copy link
Contributor Author

conorsch commented Jun 9, 2021

Not just a release bump: I tacked on a clarifying commit as a follow-up to #707, as discussed in standup today.

@eloquence
Copy link
Member

I've run sdw-admin --apply with these changes and the symlink was set to the correct target. 🎉

@eloquence
Copy link
Member

I've also tested without the fixup commit 4027ae4, and that resulted in a symlink to /opt/sdw/mimeapps.list.sd-large-buster-template, which does not exist. So now we know what grains["id"] actually resolves to in this situation: sd-large-buster-template.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4027ae4 looks good and erik has confirmed the fix

@sssoleileraaa sssoleileraaa merged commit 29e290c into main Jun 9, 2021
@sssoleileraaa sssoleileraaa deleted the release-0.5.5 branch June 9, 2021 17:19
@sssoleileraaa sssoleileraaa restored the release-0.5.5 branch June 9, 2021 17:19
conorsch pushed a commit to freedomofpress/securedrop-yum-prod that referenced this pull request Jun 9, 2021
Includes changes from:

  * freedomofpress/securedrop-workstation#707
  * freedomofpress/securedrop-workstation#708

Signed with the old/current key, i.e.
22245C81E3BAEB4138B36061310F561200F4AD77
conorsch pushed a commit to freedomofpress/securedrop-yum-prod that referenced this pull request Jun 9, 2021
Includes changes from:

  * freedomofpress/securedrop-workstation#707
  * freedomofpress/securedrop-workstation#708

Signed with the old/current key, i.e.
22245C81E3BAEB4138B36061310F561200F4AD77
cfm pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants