New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 0.5.5 #708
Conversation
Follow up to #707. Make sure we're using vm_name everywhere.
Releasing the changes merged in [0]. Intentionally preserving the full-migration flag in postinst to trigger another provisioning run, in order to apply this fix for those who need it. [0] https://github.com/freedomofpress/securedrop-workstation/pull/707/files
Not just a release bump: I tacked on a clarifying commit as a follow-up to #707, as discussed in standup today. |
I've run |
I've also tested without the fixup commit 4027ae4, and that resulted in a symlink to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4027ae4 looks good and erik has confirmed the fix
Includes changes from: * freedomofpress/securedrop-workstation#707 * freedomofpress/securedrop-workstation#708 Signed with the old/current key, i.e. 22245C81E3BAEB4138B36061310F561200F4AD77
Includes changes from: * freedomofpress/securedrop-workstation#707 * freedomofpress/securedrop-workstation#708 Signed with the old/current key, i.e. 22245C81E3BAEB4138B36061310F561200F4AD77
Status
Ready for review
Description of Changes
Releasing the changes merged in [0]. Intentionally
preserving the full-migration flag in postinst to trigger another
provisioning run, in order to apply this fix for those who need it.
[0] https://github.com/freedomofpress/securedrop-workstation/pull/707/files
Testing
Visual review is sufficient.