Skip to content

Commit

Permalink
Functional tests: Resolve NoAlertPresentException
Browse files Browse the repository at this point in the history
We were getting a NoAlertPresentException due to new behavior in
geckodriver [0] where interacting with the driver closes the modal.
Thus, we do not need to explicitly accept the modal here.

[0] mozilla/geckodriver#1171
  • Loading branch information
redshiftzero committed Dec 21, 2018
1 parent 972e889 commit 8385369
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions securedrop/tests/functional/journalist_navigation_steps.py
Expand Up @@ -699,8 +699,6 @@ def _visit_edit_secret(self, type):
reset_button = self.driver.find_elements_by_css_selector(
'#button-reset-two-factor-' + type)[0]
reset_button.click()
self._alert_accept()
time.sleep(self.sleep_time)

def _visit_edit_hotp_secret(self):
self._visit_edit_secret('hotp')
Expand Down

0 comments on commit 8385369

Please sign in to comment.