Merge pull request #6011 from freedomofpress/prevent-dup-source-keys

Prevent creation of a duplicate source keypair
freedomofpress · Jun 22, 2021 · bfed762 · bfed762
2 parents 6c9fd2f + 9197446
commit bfed762
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/securedrop/source_app/main.py b/securedrop/source_app/main.py
@@ -226,11 +226,7 @@ def submit() -> werkzeug.Response:
             db.session.add(submission)
             new_submissions.append(submission)
 
-        # If necessary, generate a keypair to encrypt replies from the journalist
-        if g.source.pending or not current_app.crypto_util.get_fingerprint(g.filesystem_id):
-            current_app.crypto_util.genkeypair(g.filesystem_id, g.codename)
-            g.source.pending = False
-
+        g.source.pending = False
         g.source.last_updated = datetime.utcnow()
         db.session.commit()