Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Ansible callback for profile_tasks #2943

Closed
conorsch opened this issue Jan 27, 2018 · 0 comments
Closed

Remove unnecessary Ansible callback for profile_tasks #2943

conorsch opened this issue Jan 27, 2018 · 0 comments

Comments

@conorsch
Copy link
Contributor

Feature request

Description

The file at install_files/ansible-base/callback_plugins/profile_tasks.py was added via #1196, to provide additional information on task performance, with the goal of aiding developers in improving the server config workflow. Since we moved to Ansible v2 in #1146, the hardcoded plugin is no longer necessary.

Instead, we can ansible add a lint to ansible.cfg under [defaults]:

callback_whitelist = profile_tasks

The simplification is possible because task profiling was added to Ansible core as of v2.

User Stories

As a maintainer, I want to delete redundant code wherever possible, and lean on upstream to handle core functionality when appropriate.

@conorsch conorsch mentioned this issue Jan 27, 2018
3 tasks
ultimatecoder added a commit to ultimatecoder/securedrop that referenced this issue Oct 17, 2018
With the release of Ansible v2, "profile_tasks" is part of Ansible core.
Replacing hard-coded plugin code with appropriate Ansible configuration.

Resolves: freedomofpress#2943
kushaldas pushed a commit that referenced this issue Sep 25, 2019
With the release of Ansible v2, "profile_tasks" is part of Ansible core.
Replacing hard-coded plugin code with appropriate Ansible configuration.

Resolves: #2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants