Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore script needs updating to python 3 #4731

Closed
redshiftzero opened this issue Sep 3, 2019 · 1 comment · Fixed by #4752
Closed

restore script needs updating to python 3 #4731

redshiftzero opened this issue Sep 3, 2019 · 1 comment · Fixed by #4752
Milestone

Comments

@redshiftzero
Copy link
Contributor

Description

securedrop/install_files/ansible-base/roles/restore/files/restore.py needs updating to python 3

@redshiftzero redshiftzero added this to the 1.0.0 milestone Sep 3, 2019
@rmol
Copy link
Contributor

rmol commented Sep 4, 2019

There are other shebang lines that should be updated, among them of course backup.py. They could all be changed to use /opt/venvs/securedrop-app-code, which would ensure the virtualenv never has to be activated in production to avoid confusing failures, but that would pose a problem for developers invoking them while using custom virtualenvs. I think making production use less involved should take priority; if devs need to run things without using the Makefile targets or the dev container, they can specify their python on the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants