Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functional test coverage for making the file submissions disallowable on the admin interface #5008

Closed
redshiftzero opened this issue Nov 20, 2019 · 2 comments · Fixed by #5027
Labels
good first issue help wanted Issues we would definitely appreciate volunteer help with

Comments

@redshiftzero
Copy link
Contributor

Description

In #4879 we had a contribution enabling an instance to turn off file submissions - instead the instance would accept only messages. This ticket is for adding Selenium-based functional test coverage for this feature in the admin interface. The test would ideally have the following steps:

  1. Admin disables file submissions.
  2. Source users visits. We confirm that they cannot submit files, only messages.
  3. Source submits a message.
  4. Admin re-enables file submissions.
  5. Source visits again and submits a file successfully.

A good starting point would be looking at similar tests here: https://github.com/freedomofpress/securedrop/blob/develop/securedrop/tests/functional/test_admin_interface.py

@redshiftzero redshiftzero added help wanted Issues we would definitely appreciate volunteer help with good first issue labels Nov 20, 2019
@DrGFreeman
Copy link
Contributor

DrGFreeman commented Nov 20, 2019

@redshiftzero, I can take this one. Getting familiar with the functional tests by now 😉.

Of course, if @wbaid wants to implement the tests (as initiator of #4879), I am fine with that too. Just advise.

@redshiftzero
Copy link
Contributor Author

excellent, feel free to take this one @DrGFreeman 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted Issues we would definitely appreciate volunteer help with
Projects
None yet
2 participants