Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_version script is broken #5530

Closed
conorsch opened this issue Sep 25, 2020 · 0 comments · Fixed by #5538
Closed

update_version script is broken #5530

conorsch opened this issue Sep 25, 2020 · 0 comments · Fixed by #5538

Comments

@conorsch
Copy link
Contributor

Description

The ./update_version.sh script in the repository is broken.

Steps to Reproduce

Run the script with a fake version:

./update_version.sh 1.8.4

Expected Behavior

Script updates all necessary targets, exits without error.

Actual Behavior

Script fails, complaining about a missing file:

$ ./update_version.sh 1.8.4
sed: can't read install_files/securedrop-app-code/debian/control: No such file or directory

Comments

Looks like the changes in #5465 broke it. We'll need to resolve prior to bumping to 1.6.0~rc2, and the fix should land in both develop and release/1.6.0 branches.

@eloquence eloquence added this to SecureDrop Sprint #59 - 9/17-10/1 in SecureDrop Team Board Sep 25, 2020
@emkll emkll moved this from SecureDrop Sprint #59 - 9/17-10/1 to In Development in SecureDrop Team Board Sep 28, 2020
@emkll emkll removed this from In Development in SecureDrop Team Board Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants