Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_version.sh script #5538

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Sep 28, 2020

Status

Ready for review

Description of Changes

Fixes #5530 :

  • App control file no longer contains application version
  • Updates Focal Debian changelog version for securedrop-app-code
  • Use control file templates for securedrop-ossec related packages.

Changes proposed in this pull request:

Testing

  • ./update_version.sh X.Y.Z works as expected for a release version string
  • ./update_version.sh W.X.Y-rcZ works as expected for a release candidate

Deployment

Dev env only

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

* App control file no longer contains application version
* Updates Focal Debian changelog version for securedrop-app-code
* Use control file templates for securedrop-ossec related packages.
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan passes, ossec control files and new changelog updated correctly.

@zenmonkeykstop zenmonkeykstop merged commit 9d00789 into develop Sep 28, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Sep 28, 2020
@emkll emkll deleted the 5530-fix-update-script branch September 28, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

update_version script is broken
2 participants