Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacement of pyotp with equivalent functionality in cryptography #5613

Closed
rmol opened this issue Nov 3, 2020 · 6 comments
Closed
Assignees

Comments

@rmol
Copy link
Contributor

rmol commented Nov 3, 2020

Description

The cryptography package contains support for HOTP/TOTP. We should see if it can do everything we use pyotp for. Those two packages are excellent and maintained, but our update protocol is laborious enough that we should eliminate any dependencies we can.

Edited by @eloquence to reflect removal of scrypt dependency, 2021-09-28

@evilaliv3
Copy link
Contributor

@rmol : Actually i come to this evaluation myself within @globaleaks and i just made this change.

Here you can find the code i used to reimplement TOTP by means of python-cryptography: globaleaks/GlobaLeaks@64750f4

@rmol
Copy link
Contributor Author

rmol commented May 7, 2021

Hey, thanks @evilaliv3! That should save us some time. 🙂

@nabla-c0d3
Copy link
Contributor

nabla-c0d3 commented Sep 25, 2021

The dependency to scrypt was removed in #5694.

@eloquence eloquence changed the title Investigate replacement of pyotp and scrypt with equivalent functionality in cryptography Investigate replacement of pyotp with equivalent functionality in cryptography Sep 29, 2021
@eloquence
Copy link
Member

Thanks, retitled accordingly!

@nabla-c0d3
Copy link
Contributor

PR at #6679 is ready

@nabla-c0d3
Copy link
Contributor

PR #6679 was merged so this issue can be closed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants