test: use urandom in test #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmc
force-pushed
the
urandom
branch
6 times, most recently
from
cbfcda7
to
813bc79
Compare
tmc
changed the title
ghost
mentioned this pull request
|
My interpretation of "Work in progress" is because @tmc wanted to demonstrate the benefit. However there is enough evidence/documentation explaining urandom will be less of a blocker than random. In the context of tests we do not care about the quality of entropy therefore there is no negative impact if we force every tool to use urandom instead of random, even for GPG or ssh keys. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
Changes proposed in this pull request:
Testing
make app-images app-test
Deployment
N/A
Checklist
N/A