Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #2584

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Add codecov #2584

merged 2 commits into from
Jan 3, 2018

Conversation

tmc
Copy link
Contributor

@tmc tmc commented Nov 17, 2017

Status

Ready for review

Description of Changes

Changes proposed in this pull request:

Adds codecov support.

Sample report: https://codecov.io/gh/freedomofpress/securedrop/branch/add-codecov

Testing

N/A

Deployment

N/A

@tmc tmc requested a review from a user November 17, 2017 05:56
@ghost ghost removed their request for review November 17, 2017 08:42
@tmc tmc force-pushed the add-codecov branch 5 times, most recently from 394ec51 to fb967eb Compare November 19, 2017 05:36
@ghost ghost added feature tests labels Dec 17, 2017
@ghost
Copy link

ghost commented Dec 17, 2017

@tmc it needs rebase I'm afraid.

@tmc tmc force-pushed the add-codecov branch 3 times, most recently from 5d602f3 to 3f2f4d0 Compare December 31, 2017 08:10
@tmc
Copy link
Contributor Author

tmc commented Dec 31, 2017

Rebased.

@codecov-io
Copy link

codecov-io commented Dec 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (develop@37ea177). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2584   +/-   ##
==========================================
  Coverage           ?   89.78%           
==========================================
  Files              ?       30           
  Lines              ?     1743           
  Branches           ?      202           
==========================================
  Hits               ?     1565           
  Misses             ?      131           
  Partials           ?       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea177...cfe6b20. Read the comment docs.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up FPFers, I turned on codecov a few weeks back for this repo - merging this since coverage reports are indeed being uploaded now - thanks @tmc :-)

@redshiftzero redshiftzero merged commit fab131b into freedomofpress:develop Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants