Fix async genkey logging #2772
Merged
Fix async genkey logging #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Flask, current_app is a werkzeug LocalProxy which uses thread (or greenlet) local storage. Since async_genkey runs in another thread it's invalid to call it in this manner.
tmc
force-pushed
the
fix-async-genkey-logging
branch
from
3749d9d
to
fd136d4
Compare
|
This failure appears to be a flake, can someone re-run? |
redshiftzero
approved these changes
Dec 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
This skips calling current_app which is invalid to do from a separate thread (which async_genkey runs in).
Fixes #2609.
Testing
CI
Deployment
N/A
Checklist
N/A