Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: replace abandoned pytest-capturelog with pytest-catchlog #2774

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

tmc
Copy link
Contributor

@tmc tmc commented Dec 31, 2017

Status

Ready for review

Description of Changes

Fixes #2773.

Changes proposed in this pull request:

This addressing deprecation warnings you see when running tests with pytest -s

Unfortunately these two can't be installed concurrently which could mean development environments could be negatively impacted by this change (see #2773).

Testing

CI

Deployment

N/A

Checklist

N/A

This addressing deprecation warnings you see when running tests with `pytest -s`
@tmc tmc requested a review from a user December 31, 2017 00:42
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable, thanks for the clear explanation in ticket #2773 😄 - approved for merge

@redshiftzero redshiftzero merged commit 044b2c6 into freedomofpress:develop Dec 31, 2017
@ghost ghost added the tests label Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants