Change sad crypto_util doctest sample text #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the loss of two great contributors to this project to suicide, I think it would be nice to remove this rather depressing doctest sample text. The new text reads, in Spanish, "Good day, beautiful world!"
heartsucker
approved these changes
Feb 7, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2982 +/- ##
========================================
Coverage 89.28% 89.28%
========================================
Files 31 31
Lines 1810 1810
Branches 209 209
========================================
Hits 1616 1616
Misses 144 144
Partials 50 50Continue to review full report at Codecov.
|
|
Merging because this makes the world a little brighter. |
ghost
added
the
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Given the loss of two great contributors to this project to suicide, I think it would be nice to remove this rather depressing doctest function sample text. The new text reads, in Spanish, "Good day, beautiful world!"
Testing
python -m doctest -v crypto_util.pyshould suffice as only doctest function documentation is changing.