i18n: display localizer credits for inclusion in the release blog #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 20, 2018 12:00
So it is properly aligned as class methods. Only whitespace modification and the class I81NTool(object) added to look consistent.
Because there is no way to override the defaults otherwise.
The logic of tests remains the same but use command line options via
the main() method such as:
i18n_tool.I18NTool().main([
'--verbose',
'translate-desktop',
'--translations-dir', str(tmpdir),
'--sources', in_files['source'],
'--extract-update',
instead of exposing i18n_tool internal details to the tests:
kwargs = {
'translations_dir': str(tmpdir),
'sources': in_files['source'],
'extract_update': True,
'compile': False,
'verbose': logging.DEBUG,
'version': version.__version__,
}
args = argparse.Namespace(**kwargs)
tool = i18n_tool.I18NTool()
tool.setup_verbosity(args)
the major drawback of the Namespace mockup is that it must contain all
arguments used by the function, even if the argument has a default
because the arguments are not parsed. It is an unecessary burden
during the test maintenance.
The parser and implementation functions for
translate_{desktop,messages} are grouped together instead of being
separated by the more generic get_args function. This will help
clustering new functions.
To update the list of supported languages in the documentation and commit the change so the associated commit message is always the same.
A side effect of running pip-compile is the upgrade to cryptography==2.2 which was manually overriden to keep cryptography==2.0.3 so there is no upgrade, just new modules being added.
ghost
added
feature
i18n
ghost
force-pushed
the
wip-dachary-i18n-tool
branch
from
7bd124a
to
ad81086
Compare
ghost
changed the title
ghost
force-pushed
the
wip-dachary-i18n-tool
branch
2 times, most recently
from
a51cc22
to
af0186f
Compare
ghost
force-pushed
the
wip-dachary-i18n-tool
branch
3 times, most recently
from
c059c03
to
2691ed8
Compare
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
馃敶 Work in progress 馃敶
Description of Changes
Display localizer credits for inclusion in the release blog
Testing
./i18n_tool.py --verbose update-from-weblate# will create two commits with updates from weblate./i18n_tool.py --verbose credits --username admin --password adminpassword# requires a weblate admin account (@redshiftzero you have admin permissions)update-from-weblateDeployment
N/A
Checklist
If you made changes to documentation:
make docs-lint) passed locally