Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code ownership responsibilities #4012

Merged
merged 1 commit into from Jan 3, 2019

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

This PR updates the code ownership responsibilities since @emkll and @kushaldas became SecureDrop maintainers

Testing

Are you happy with the code ownership here? Let me know if you would prefer not to be listed for a particular directory

Note: code owners must have write access to the repo, so for /docs/ we should feel free to request review from others without write access as needed

Deployment

None, dev only

Checklist

N/A

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #4012 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4012   +/-   ##
========================================
  Coverage    84.69%   84.69%           
========================================
  Files           43       43           
  Lines         2763     2763           
  Branches       299      299           
========================================
  Hits          2340     2340           
  Misses         355      355           
  Partials        68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da58850...6bd447b. Read the comment docs.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Copy link
Contributor

@heartsucker heartsucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@conorsch conorsch self-requested a review January 3, 2019 16:40
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@redshiftzero redshiftzero merged commit d539c13 into develop Jan 3, 2019
@redshiftzero redshiftzero deleted the docs-update-code-owners branch January 3, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants