Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return user id when creating auth token #4088

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Conversation

heartsucker
Copy link
Contributor

Status

Ready for review / Work in progress

Description of Changes

Fixes #4081

Return the journalist's UUID when they create an auth token.

Testing

  • Verify the name journalist_uuid is a reasonable name for this field
  • make test like usual

Deployment

This is a backwards compatible API change.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@kushaldas
Copy link
Contributor

Kicking the failed GUI tests.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. 👍

@kushaldas kushaldas merged commit ba4ffce into develop Jan 30, 2019
@emkll emkll mentioned this pull request Feb 19, 2019
17 tasks
@heartsucker heartsucker deleted the user-id-auth-token branch February 27, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants