Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] More detailed guide to investigating and enabling logs #4359

Merged
merged 1 commit into from Apr 26, 2019

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Apr 20, 2019

"Look at these logs" is one of the most common support responses, so having canonical and correct information in the public docs is important and reduces the risk of small errors in these communications.

As part of this PR, I moved the securedrop-admin logs instructions into an include file, since it is a common operation we will likely want to refer to again in future, and renamed the section to "Investigating Logs", since it is now hopefully beginning to be deserving of such a title. ;)

Resolves #4356

Status

Ready for review

Test plan

This PR includes instructions for enabling error logging on the source interface. To test, follow these instructions on production hardware or a prod VM (logging on the source interface is enabled in staging, but not in prod).

To verify that errors are logged, you may want to produce an exception by introducing an error into a component of the Source Interface in /var/www/securedrop (and of course, later reverting it); I tested by making a syntax error modification in source.py. Confirm that you are in fact seeing the Internal Server Error on the Source Interface; if so, you should be seeing it in the log file, as well.

Checklist

  • Doc linting (make docs-lint) passed locally

docs/includes/get-logs.txt Show resolved Hide resolved
docs/logging.rst Outdated Show resolved Hide resolved
docs/logging.rst Outdated Show resolved Hide resolved
docs/logging.rst Outdated Show resolved Hide resolved
"Look at these logs" is one of the most common support responses,
so having canonical and correct information in the public docs
is important and  reduces the risk of small errors in these
communications.

I moved the `securedrop-admin logs` instructions into an include
file, since it is a common operation we will likely want to refer
to again in future, and renamed the section to "Investigating
Logs", since it is now hopefully beginning to be deserving of
such a title. ;)

Resolves #4356
@eloquence eloquence changed the title More detailed guide to investigating and enabling logs [docs] More detailed guide to investigating and enabling logs Apr 25, 2019
@zenmonkeykstop zenmonkeykstop self-assigned this Apr 26, 2019
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop merged commit 6f471d8 into develop Apr 26, 2019
SecureDrop Team Board automation moved this from Ready for review to Done Apr 26, 2019
@zenmonkeykstop zenmonkeykstop deleted the docs-enable-logging branch April 26, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Docs point to source error logs which are not collected by default
2 participants