Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve linting issues, consolidate linting makefile targets #4432

Merged
merged 7 commits into from
May 16, 2019
Merged

Resolve linting issues, consolidate linting makefile targets #4432

merged 7 commits into from
May 16, 2019

Commits on May 16, 2019

  1. linting: install pyenchant in development requirements

    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    d2e943f View commit details
    Browse the repository at this point in the history

  2. linting: remove separate CI lint target, remove docs-lint from lint

    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    4874b36 View commit details
    Browse the repository at this point in the history

  3. linting: suppress no-member warnings 

    tons of false positives, we can re-enable this later
    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    a2a3bd7 View commit details
    Browse the repository at this point in the history

  4. linting: install enchant in CI

    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    3326db0 View commit details
    Browse the repository at this point in the history

  5. linting: update PR template

    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    1cf0ba4 View commit details
    Browse the repository at this point in the history

  6. ci: install enchant in staging box 

    the choice here is to:

1. install enchant in the staging machine
2. break up development dependencies into what is needed for linting
and what is needed for the provisioning of staging machines

selecting the former, as having too many requirements files has
caused major confusion in the past.
    @redshiftzero
    redshiftzero authored and Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    a135c7e View commit details
    Browse the repository at this point in the history

  7. Updates GCP CI base image 

    Rebuilds the GCP CI box on Stretch, rather than Xenial. Doing so fixed a
recurring problem during the "make staging" run where the staging VMs
did not come back up, causing Ansible to timeout during wait, and the
entire build to fail.
    Conor Schaefer committed May 16, 2019
    Configuration menu
    Copy the full SHA
    45b7139 View commit details
    Browse the repository at this point in the history