Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder hash #4483

Merged
merged 3 commits into from May 31, 2019
Merged

Update builder hash #4483

merged 3 commits into from May 31, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented May 29, 2019

Status

Ready for review

Description of Changes

Towards #4439 and fixes #4484

Testing

CI should pass (including builder tests)

Deployment

Build environment only.

Builder needed security updates
@redshiftzero
Copy link
Contributor

See #4484, let's merge this when the deb-tests CI job passes

redshiftzero
redshiftzero previously approved these changes May 29, 2019
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally via make build-debs that the security update test passes, good to merge when deb-tests CI job passes

@redshiftzero
Copy link
Contributor

deb-tests CI job fails here due to an unrelated error that we should fix in this PR but not backport into release/0.13.0. I've verified that make build-debs works locally for the purposes of the 0.13.0 release today.

@eloquence eloquence moved this from Current Sprint - 5/30-6/12 to Ready for review in SecureDrop Team Board May 30, 2019
Builder image needed further updates
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deb-tests CI job is passing, so approving

@redshiftzero redshiftzero merged commit 52ae022 into develop May 31, 2019
SecureDrop Team Board automation moved this from Ready for review to Done May 31, 2019
@redshiftzero redshiftzero deleted the update-builder-20190529 branch May 31, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Only run lint, deb-tests CI jobs on builder image updates
2 participants