Use archive module in securedrop-admin logs playbook
#4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straightforward archive operation and does not require running tar manually. Resolves #4357
Codecov Report
@@ Coverage Diff @@
## develop #4497 +/- ##
========================================
Coverage 83.21% 83.21%
========================================
Files 45 45
Lines 3069 3069
Branches 332 332
========================================
Hits 2554 2554
Misses 430 430
Partials 85 85Continue to review full report at Codecov.
|
eloquence
requested review from
conorsch,
emkll,
kushaldas and
msheiny
as code owners
kushaldas
approved these changes
Jun 5, 2019
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward archive operation and does not require running tar manually.
Resolves #4357
Status
Ready for review
Test plan
In a virtualized or prod environment, run the
securedrop-admin logscommand before and after this change. The resulting archives should be identical.If you made changes to
securedrop-admin:make -C admin test) pass in the admin development container