Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "now" from "SecureDrop now uses automatically generated .." #4512

Merged
merged 1 commit into from Jun 10, 2019

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jun 7, 2019

The change this refers to was made in February 2017, in this commit: b85bffc

Status

Ready for review

Checklist

String change only, have not run tests locally but have checked for additional occurrences of the string to ensure it is not repeated or matched against.

@codecov-io
Copy link

Codecov Report

Merging #4512 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4512   +/-   ##
========================================
  Coverage    82.63%   82.63%           
========================================
  Files           45       45           
  Lines         3115     3115           
  Branches       337      337           
========================================
  Hits          2574     2574           
  Misses         456      456           
  Partials        85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d066eb...176ac7c. Read the comment docs.

@eloquence eloquence added this to Ready for review in SecureDrop Team Board Jun 8, 2019
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. Approved 🌈

@kushaldas kushaldas merged commit 97d603d into develop Jun 10, 2019
SecureDrop Team Board automation moved this from Ready for review to Done Jun 10, 2019
@kushaldas kushaldas deleted the the-future-is-now branch June 10, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants