Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecureDrop screenshots for source, journalist and admin guides #4557

Merged
merged 2 commits into from Jun 28, 2019

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jun 27, 2019

This also includes a correction in the docs that describe a screenshot, which refers to the "Exit" button (it was once briefly called that, but is now back to "Log out").

Resolves #4529

Status

Ready for review

How to review

I recommend using GitHub's rich diff feature to ensure that the content of each screenshot matches the one it replaces. Click the "rich diff" icon for each file on the "Files changed" tab:

Screenshot from 2019-06-27 21-48-41

Checklint

  • make docs-lint passed locally

@eloquence
Copy link
Member Author

eloquence commented Jun 27, 2019

I used @rmol's sceenshots fixes to work around a bug in develop (#4558) where all screenshots by the functional tests produce tofu instead of legible characters. It saved a fair bit of time, but I still had to manually crop several screenshots, and retook some to capture the right target area.

Note I forced the version string to 0.14.0 for a cleaner reading experience.

Even with John's fixes, my first run for the admin UI screenshots produced a lot of screens without the logo so I'm not including those in this PR; will do another run to see if that's flakiness or consistent.

@eloquence eloquence added this to Ready for review in SecureDrop Team Board Jun 27, 2019
This also includes a correction in the docs that describe a
screenshot, which refers to the "Exit" button (it was once briefly
called that, but is now back to "Log out").
@eloquence eloquence force-pushed the docs-screenshot-updates-round-1 branch from 6cf1c7b to 88992fd Compare June 27, 2019 05:46
@eloquence eloquence changed the title Update SecureDrop screenshots for source and journalist guide Update SecureDrop screenshots for source, journalist and admin guides Jun 28, 2019
@eloquence
Copy link
Member Author

With the changes in #4559 and more manual editing/re-taking of some screenshots, I was able to update the admin guide screenshots as well.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@redshiftzero redshiftzero merged commit 0551080 into develop Jun 28, 2019
SecureDrop Team Board automation moved this from Ready for review to Done Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Screenshots in source guide are out of date
2 participants